Update SARIF test fixture to match updated spec-char-escape documentation - #1754
Merged
Conversation
Co-authored-by: coliff <1212885+coliff@users.noreply.github.com>
Deploying htmlhint with
|
| Latest commit: |
28dc2f1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4b961604.htmlhint.pages.dev |
| Branch Preview URL: | https://copilot-fix-ci-cd-tests-fail.htmlhint.pages.dev |
Copilot
AI
changed the title
[WIP] Fix failing tests in CI/CD pipeline
Update SARIF test fixture to match updated spec-char-escape documentation
Nov 1, 2025
coliff
marked this pull request as ready for review
November 1, 2025 09:08
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1754 +/- ##
===========================================
+ Coverage 96.99% 100.00% +3.00%
===========================================
Files 2 1 -1
Lines 1628 1 -1627
Branches 335 0 -335
===========================================
- Hits 1579 1 -1578
+ Misses 49 0 -49 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SARIF formatter test was failing because the test fixture contained outdated markdown for the
spec-char-escaperule. The rule documentation was updated to include a "Why this rule is important" section explaining XSS prevention, but the test fixture still expected the old format.Changes
test/cli/formatters/sarif.sarifto include the "Why this rule is important" section in thespec-char-escaperule's markdown help textThe fix synchronizes the test fixture with the current documentation content that explains how unescaped HTML special characters can lead to rendering issues and XSS vulnerabilities.
Original prompt
This section details on the original issue you should resolve
<issue_title>Tests are failing in CI/CD</issue_title>
<issue_description>Error